Closed bonedaddy closed 4 years ago
Merging #463 into master will decrease coverage by
0.09%
. The diff coverage is57.36%
.
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
- Coverage 52.56% 52.47% -0.08%
==========================================
Files 43 43
Lines 4253 4302 +49
==========================================
+ Hits 2235 2257 +22
- Misses 1519 1538 +19
- Partials 499 507 +8
Impacted Files | Coverage Δ | |
---|---|---|
api/v2/api.go | 86.04% <ø> (ø) |
:arrow_up: |
api/v2/routes_rtfsp_usage.go | 34.33% <0%> (ø) |
:arrow_up: |
api/v2/routes_rtfs.go | 36.91% <0%> (ø) |
:arrow_up: |
api/v2/routes_payment.go | 25.78% <100%> (ø) |
:arrow_up: |
utils/cmc.go | 54.44% <53.58%> (-16.15%) |
:arrow_down: |
api/v2/utils.go | 51.36% <75%> (+0.66%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e00b8a0...ee73991. Read the comment docs.
:construction_worker: Purpose
Closes https://github.com/RTradeLtd/Temporal/issues/420. Currently there is some ungraceful handling of people uploading a duplicate file. If the upload a duplicate file, we abort early and error out.
:rocket: Changes
Instead of aborting early and error out, we return a response as if the request was normally processed. Additionally this includes a fix for CMC deprecating their old api
:warning: Breaking Changes
I don't think there should be any breaking changes, since we're simply adjusting the response message and code sent back.