search

RTradeLtd / TxPB

TemporalX gRPC and Documentation Resources
https://docsx.temporal.cloud
GNU Affero General Public License v3.0
14 stars 1 forks source link

Multi Platform Fix (JS) #32

Closed bonedaddy closed 4 years ago

bonedaddy commented 4 years ago

Unfortunately the usage of the gogoproto options for some "niceties" when interacting with the protocol buffers from Golang was causing issues when generating the code in other languages. This PR removes the usage of the custom gogoproto options, but keeps compiling the go generated code using gogoproto.

In theory this should be compatible with previous versions of TxPB however I think because this "breaks" the way you interact with TxPB from go code, it warrants a major version bump. As such this commit also inits a go.mod at v2.

Additionally this overhauls how we generate the js gRPC client stubs such that they no longer use grpc-web and instead use grpc-node.

Closes https://github.com/RTradeLtd/TxPB/issues/22

TODO:

bonedaddy commented 4 years ago

Looks like to properly do this, I need to regenerate the bindings for javascript without using grpc-web