search

RTradeLtd / TxPB

TemporalX gRPC and Documentation Resources
https://docsx.temporal.cloud
GNU Affero General Public License v3.0
14 stars 1 forks source link

prevent unpredictable panics from missing logger #93

Closed xiegeo closed 4 years ago

xiegeo commented 4 years ago

Although our usage from node is fixed already. This prevents similar errors from occurring for other developers.

github-actions[bot] commented 4 years ago

CLA Assistant Lite All Contributors have signed the CLA.

codecov[bot] commented 4 years ago

Codecov Report

Merging #93 into master will increase coverage by 0.14%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   72.25%   72.39%   +0.14%     
==========================================
  Files           9        9              
  Lines         400      402       +2     
==========================================
+ Hits          289      291       +2     
  Misses         84       84              
  Partials       27       27
Impacted Files Coverage Δ
go/rep_client.go 54.84% <100.00%> (+1.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12f7d91...0a0ff47. Read the comment docs.