search

RUB-EP1 / amplitude-serialization

Prototype for the amplitude model serialization format
https://rub-ep1.github.io/amplitude-serialization
MIT License
2 stars 1 forks source link

DOC: add preview of AmpForm-DPD model deserialization #47

Closed redeboer closed 5 months ago

redeboer commented 5 months ago

Added a page for Lc to pKpi that illustrates https://github.com/ComPWA/ampform-dpd/pull/132 (preview).

[!WARNING] The model validation does not work yet, for now the page just illustrates the symbolic rendering of the deserialized model. Keep an eye on https://github.com/ComPWA/ampform-dpd/issues/133 for upcoming fixes.

redeboer commented 5 months ago

@mmikhasenko the page has been converted from a Jupyter notebook with MyST syntax and is not yet optimal for Quarto. On the road today, hope to get back to that later today. The PR should be merged before tomorrow afternoon.

mmikhasenko commented 5 months ago

Looks great, @redeboer. I could not spot any problems right away: maybe it matches once the nan is solved.

mmikhasenko commented 5 months ago

Combination of s (GeV^2), and masses (GeV) does not look right, if the order of the argument changes (production vs decay of resonance)

image
mmikhasenko commented 5 months ago

p^{2L} is missing.

image

my form-factor includes z^{2l} in the numerator, that is why there is no p^{2l+1} in julia code. Just 2p/sqrt{s}

redeboer commented 5 months ago

maybe it matches once the nan is solved.

For that it would be easiest to get a section with checksums for dynamics. But indeed perhaps the points you pointed out might fix it already.

redeboer commented 5 months ago

I'm doubting btw between merging this PR for now to get at least the preview up or addressing the issues first. Don't think I can handle that quickly because it might require a new prerelease of AmpForm-DPD.

redeboer commented 5 months ago

Combination of s (GeV^2), and masses (GeV) does not look right, if the order of the argument changes (production vs decay of resonance)

Good point, though more of a design problem + latex rendering problem? You would just have to square the mass. But yeah if there is some argument swapping going on programmatically this is tricky...

redeboer commented 5 months ago

@mmikhasenko seeing that CI takes some time, I would prefer to merge this one (and #45?) asap. Remaining issues will be addressed through https://github.com/ComPWA/ampform-dpd/issues/133 and a follow-up PR here.

redeboer commented 5 months ago

Ah sorry, hadn't noticed that the requirement for an approval was switched off... so it automerged already