Extend validation - Githubissues

RUB-EP1 / amplitude-serialization

Prototype for the amplitude model serialization format

https://rub-ep1.github.io/amplitude-serialization

MIT License

2 stars 1 forks source link

Extend validation #55

Closed IlyaSegal closed 5 months ago

IlyaSegal commented 5 months ago

Closes #44 and closes #36

Implemented validation checks for different lineshapes.

mmikhasenko commented 5 months ago

@IlyaSegal a few suggestions:

rename name -> point in the validation section. It makes more sense, I think. I've done it already in the X2pipipi_compass file.
- not all BWs in lc2ppiK are functions of m_12^2, only Deltas. The K(..) are functions of m_23^2, while Lambdas are functions of m_31^2

otherwise, looks good to me

mmikhasenko commented 5 months ago

@IlyaSegal the conflicts should be straightforward, shell we merge it today?

IlyaSegal commented 5 months ago

@mmikhasenko validation for X to 3pi is there. The only thing that is left is to implement validation of lineshapes to Python notebook. That's why the test fails for now. @redeboer, can you help with this?