search

RUB-NDS / Terrapin-Scanner

This repository contains a simple vulnerability scanner for the Terrapin attack present in the paper "Terrapin Attack: Breaking SSH Channel Integrity By Sequence Number Manipulation".
https://terrapin-attack.com
Apache License 2.0
931 stars 62 forks source link

Add nightly build #28

Closed PythonCoderAS closed 7 months ago

PythonCoderAS commented 7 months ago

This will add a new tag nightly to the main branch’s tag updated once a day.

TrueSkrillor commented 7 months ago

Since we are building the final image from scratch, I don't see any advantages over using ghcr.io/rub-nds/terrapin-scanner:main. What would be the advantage of having daily nightly builds when each push already results in updated images being built?

PythonCoderAS commented 7 months ago

Since we are building the final image from scratch, I don't see any advantages over using ghcr.io/rub-nds/terrapin-scanner:main. What would be the advantage of having daily nightly builds when each push already results in updated images being built?

Nightly builds usually are meant for repos that get a lot of commits per day. I guess in this case it really doesn't make too much sense.

TrueSkrillor commented 7 months ago

Yes, but in this case we wouldn't have builds on every commit. I'll close this PR as I think this isn't needed for now.