Docker Image Updates - Githubissues

RVSagar / uw-auto-rc-car

Autonomous RC car project for a future University of Waterloo Mechatronics course.

MIT License

3 stars 1 forks source link

Docker Image Updates #2

Closed stephenwang5 closed 4 years ago

stephenwang5 commented 4 years ago

I appologize for the big PR. The summary of the major changes is as follows:

Improved the tagging and building of Dockerfiles
Changed the base image to run Melodic instead of Kinetic (don't worry the existing simulation still works just fine)
Added VNC and remote rendering functionalities to the base image
Added logging functionalities to simple_lane_demo_sim.launch file
Added new command line arguments to both start_docker.sh and simple_lane_demo_sim.launch to allow quick changes at runtime
Tensorflow image WIP
Non-root user for the base image WIP (some graphics applications doesn't work correctly as root)

Please leave any suggestions, comments, or questions bellow. I'll keep the PR sizes smaller in the future.

RVSagar commented 4 years ago

Thanks, this looks great overall! One thing, can you move the VNC functionality to something like 'DockerfileBase.VNC' and leave Dockerfile.Base as is (i.e., same as what's on the Master branch now)? Just want to have the base image as bare bones as possible for users that don't need VNC etc.

stephenwang5 commented 4 years ago

The old "base" image still runs on Kinetic and thus require the manual Gazebo update which doesn't look very elegant. Should I remove that one VNC layer and keep the other parts, including the utilities like curl, as the updated base file and remove the old one?

RVSagar commented 4 years ago

Good point, yeah that sounds fine to me. The base image can be updated to Melodic since you've proven that everything works fine

stephenwang5 commented 4 years ago

Getting the OpenNI toolkit and Astra camera driver to work in Melodic will take a bit more time but other than that it's all good

RVSagar commented 4 years ago

sounds good, do you mind opening an issue regarding the OpenNI toolkit and Astra camera driver functionality in Melodic just so we don't forget about it. I'll merge this now, thanks for the changes!