search

RWAP / jquery-ui-touch-punch

A duck punch for adding touch events to jQuery UI
http://touchpunch.furf.com/
103 stars 29 forks source link

Replace deprecated $.fn.bind/unbind #36

Closed smartexcan closed 8 months ago

smartexcan commented 8 months ago

Related: https://github.com/RWAP/jquery-ui-touch-punch/commit/f84778610abd5489ceed0618fa82e273341e5371 https://github.com/RWAP/jquery-ui-touch-punch/issues/27

When the deprecated $.proxy was replaced, the deprecated $.fn.bind and $.fn.unbind were used instead of changing only the use of proxy to the native function bind method.

This PR corrects this and adds the intended changes.

melloware commented 8 months ago

We should bump the comments in the file to 1.1.2

RWAP commented 8 months ago

Done

melloware commented 8 months ago

@smartexcan is this working for you? with this change all my integration tests seem to be failing with a Javscript error 

Javascript errors were detected in the browser console.

[[2024-03-08T16:17:50.388Z] [SEVERE] http://localhost:8247/jakarta.faces.resource/jquery/jquery-plugins.js.xhtml?ln=primefaces&v=14.0.0-SNAPSHOT&v=14.0.0-SNAPSHOT 11340:49 
Uncaught TypeError: Cannot read properties of undefined (reading 'bind')
RWAP commented 8 months ago

There is indeed a slight error in line 199 - correcting now

melloware commented 8 months ago

Thanks Integration tests passing again!