RWELabs / Stardew-Valley-Mod-Manager

[Passion Project] The Stardew Valley Mod Manager is a powerful tool that is designed to be used alongside SMAPI to help you install and manage mods, automatically install modpacks and manage your game saves.
Other
29 stars 1 forks source link

[Issue] Mod Manager freezes briefly on Splash screen when Validating Directories. #70

Closed RyanWalpole closed 2 years ago

RyanWalpole commented 2 years ago

Describe the Issue When launching the Stardew Valley Mod Manager, the splash screen seems to freeze at some point when the splash text reads "Validating Directories..."

Steps to Replicate Steps to reproduce the behavior:

  1. Open Stardew Valley Mod Manager
  2. Observe splash screen loading indicator stop animating and window cannot be moved at "Validating Directories" stage.

Expected behavior The loading indicator should continue to animate and the window should not crash.

Environment:

Suggested Resolution Seems the UI thread may be being used by the directory validation processes. As the application has become heavier, more tasks are being completed and it's started creating a hang issue. Consider moving non UI processes to a different thread?

RyanWalpole commented 2 years ago

Solution This requires a more or less entire re-write of the code base for the splash screen. It is now structured, less messy and more efficient, with processes now happening in multiple BackgroundWorkers.