Closed saharNooby closed 1 year ago
@LoganDark Maybe want to take a look before I merge? :)
looks like you ran an auto-formatter that messed up some of the assert statements. was that intended?
@LoganDark It's intended, to keep the line not too long. Did asserts break because of this?.. Code compiled and tests passed, looks like they still work
@LoganDark It's intended, to keep the line not too long.
some of the asserts get long but should still be in only 1 line. An example is if they are in the middle of a list of other one-line asserts and splitting it into a block would be very not pretty. I think the max line length should be set higher or completely disabled.
Also you should probably add a workflow to check code formatting so that we do not have to wait for your next PR for the code to be reformatted
if they are in the middle of a list of other one-line asserts and splitting it into a block would be very not pretty
I agree that there is value in symmetry of having lined-up single line statements. For me tho, it's okay to trade it off for the possibility of having all the code visible on the screen without the need to scroll long lines.
add a workflow to check code formatting
That's a good idea, I've added it to my backlog.
For me tho, it's okay to trade it off for the possibility of having all the code visible on the screen without the need to scroll long lines.
I don't think the lines are so long that becomes an issue, but whatever I suppose
I forgot about the new Q8_1 ;D luckily #74 includes it
Notable changes:
rwkv.cpp
file version was bumped to101
Q4_2
format was removed