Closed wshafer closed 7 years ago
FYI - Tests do pass, but Travis-CI's HHVM image is currently broken. Upstream issue created.
FYI - If I'm reading the upstream issue right, HHVM looks like it will not be fixed on Precise builds. Gonna leave Trusty as the build OS for now.
You've been going at it! But I agree, that's a fair solution for now.
FWIW, supporting HHVM is not priority in most larger frameworks anymore, so if you feel like it's holding you back, I suggest dropping it from builds.
Marco Pivetta
On Wed, May 10, 2017 at 9:20 AM, Wesley Overdijk notifications@github.com wrote:
You've been going at it! But I agree, that's a fair solution for now.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RWOverdijk/AssetManager/pull/204#issuecomment-300397496, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJakHf0c-ZuV8PWCEzEqdcO7rBuC6h-ks5r4WVRgaJpZM4NSlwd .
@RWOverdijk - If you agree I'll yank HHVM from the Travis build.
Never mind... what was I thinking? Precise is EOL anyway and we should be testing against Trusty.
@wshafer Also, it's running now. Might as well keep it in, right? :)
@wshafer Maybe this should be closed?
Yep. I'll have a new and improved one soon.
Sets the minimum requirement to ZF3 and replaces deprecated container-interop to PSR-11
Other updates: Vagrant file taken from ZF Skeleton for quick development (can be removed if needed) Removed composer.lock file