RWOverdijk / AssetManager

AssetManager written for zf2. Managing assets for zend framework 2
BSD 2-Clause "Simplified" License
211 stars 83 forks source link

[BC break] Remove ZF2 + PSR-11 #204

Closed wshafer closed 7 years ago

wshafer commented 7 years ago

Sets the minimum requirement to ZF3 and replaces deprecated container-interop to PSR-11

Other updates: Vagrant file taken from ZF Skeleton for quick development (can be removed if needed) Removed composer.lock file

wshafer commented 7 years ago

FYI - Tests do pass, but Travis-CI's HHVM image is currently broken. Upstream issue created.

https://github.com/travis-ci/travis-ci/issues/7712

wshafer commented 7 years ago

FYI - If I'm reading the upstream issue right, HHVM looks like it will not be fixed on Precise builds. Gonna leave Trusty as the build OS for now.

RWOverdijk commented 7 years ago

You've been going at it! But I agree, that's a fair solution for now.

Ocramius commented 7 years ago

FWIW, supporting HHVM is not priority in most larger frameworks anymore, so if you feel like it's holding you back, I suggest dropping it from builds.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On Wed, May 10, 2017 at 9:20 AM, Wesley Overdijk notifications@github.com wrote:

You've been going at it! But I agree, that's a fair solution for now.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RWOverdijk/AssetManager/pull/204#issuecomment-300397496, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJakHf0c-ZuV8PWCEzEqdcO7rBuC6h-ks5r4WVRgaJpZM4NSlwd .

wshafer commented 7 years ago

@RWOverdijk - If you agree I'll yank HHVM from the Travis build.

wshafer commented 7 years ago

Never mind... what was I thinking? Precise is EOL anyway and we should be testing against Trusty.

RWOverdijk commented 7 years ago

@wshafer Also, it's running now. Might as well keep it in, right? :)

RWOverdijk commented 7 years ago

@wshafer Maybe this should be closed?

wshafer commented 7 years ago

Yep. I'll have a new and improved one soon.