search

RWOverdijk / AssetManager

AssetManager written for zf2. Managing assets for zend framework 2
BSD 2-Clause "Simplified" License
211 stars 83 forks source link

Revert "Improve view helper declaration" #207

Closed RWOverdijk closed 7 years ago

RWOverdijk commented 7 years ago

Reverts RWOverdijk/AssetManager#206

RWOverdijk commented 7 years ago

@wshafer First time ever I use the revert button on Github on purpose. Heh.

wshafer commented 7 years ago

👍

h3christophe commented 7 years ago

Hello @RWOverdijk do you mind explaining why you reverted that ? 

-        'aliases' => [
-            'asset' => AssetManager\View\Helper\Asset::class
-        ],
         'factories' => [
-            AssetManager\View\Helper\Asset::class => AssetManager\Service\AssetViewHelperFactory::class
-        ]
+            'asset' => AssetManager\Service\AssetViewHelperFactory::class,
+        ],

I thought using the full class name as factory and alias to link to that full class name would be the best thing to do instead of relying only on the alias "asset"

that allows people to use both the full class and alias if they want.

Thank you