search

RWOverdijk / AssetManager

AssetManager written for zf2. Managing assets for zend framework 2
BSD 2-Clause "Simplified" License
211 stars 83 forks source link

Fix ViewHelper Configuration #215

Closed FabianKoestring closed 5 years ago

FabianKoestring commented 5 years ago

fix #214

To work with the new introduced Zend ViewHelper Zend\View\Helper\Asset the configuration of AssetManager ViewHelper asset has to be changed.

@wshafer

RWOverdijk commented 5 years ago

At first glance this seems harmless. The alias should make sure it's BC...

LGTM but like I said on twitter, I do want @wshafer to bestow his infinite wisdom upon this PR.

RWOverdijk commented 5 years ago

Also: tests seem to fail because of hhvm. But really... HHVM? who cares.

wshafer commented 5 years ago

There’s nothing really changing here other then making this follow the current flow of Zend.

Hhvm is also no longer supported by Zend so I agree who cares? Perhaps we should just pull it from the Travis file?

I am a little confused how this commit will make it work and the other doesn’t work. The plugin manager is just an instance of the service manager so it should still find the service just fine when defined as a factory key.

That said I see nothing dangerous here. Plus it adds a way to have ide’s autocomplete features work

RWOverdijk commented 5 years ago

Your confusion is shared.

Anyway, if you say go, it's go and it can be merged and tagged.

RWOverdijk commented 5 years ago

I'll try to do this on Monday. Here's to hoping I'll remember :p

FabianKoestring commented 5 years ago

I'll try to do this on Monday. Here's to hoping I'll remember :p

Just a reminder... 😄

RWOverdijk commented 5 years ago

Thanks for the reminder :)

FabianKoestring commented 5 years ago

Thanks @RWOverdijk for merging. Packagist (https://packagist.org/packages/rwoverdijk/assetmanager) cant find the new release. Is this normal behavior?

RWOverdijk commented 5 years ago

You're impatient aren't you haha.

Packagist has update cycles. But I've manually updated it just for you. ❤️

Ocramius commented 5 years ago

@RWOverdijk I think you need to log out and then back into packagist via github OAuth - the update mechanism changed recently.