RWS / Multiselect-ComboBox

The multi selection combo box is a WPF custom control with multiple item selection capabilities, along with customizable features to group, sort and filter items in the collection.
Apache License 2.0
182 stars 55 forks source link

Make tab key functional when DropDown is open #65

Closed mitchcapper closed 2 years ago

mitchcapper commented 2 years ago

Right now the use of the tab key is fairly intuitive / broken when the drop down list is open.

This changes the functionality so that if the drop down is open, no matter where on the control you are focused, it does:

These seemed to make the most sense to me from a UX POV and as right now if you tab in the dropdown you are basically stuck, seems like at least a net win.

This also adds some guards to the existing key monitoring functions, largely to ignore tab (which they probably shouldn't be reacting to) along with the shift keys. Shift was needed as otherwise shift + tab caused the dropdown to reopen with on key up of shift. I would assume no one is counting on the design functionality of hitting only shift opening the drop down menu.