search

RWS / dxa-html-design

SDL Digital Experience Accelerator Whitelabel HTML Design
Apache License 2.0
4 stars 3 forks source link

Add Link reference in header to favicon #12

Open paceaux opened 8 years ago

paceaux commented 8 years ago

src/template/partials/header.hbs does not contain a reference to the favicon

Gruntfile.js copies the favicon.ico file into a temporary directory while serving the site: https://github.com/sdl/dxa-html-design/blob/master/design/Gruntfile.js#L201

It also copies the file for a build.

However, without a hard reference to the favicon, a browser may cache an old favicon and use that instead.

Using <link rel="icon" href="http://www.yoursite.com/favicon.ico?" /> will help assure that browsers show the correct favicon: http://stackoverflow.com/questions/2208933/how-do-i-force-a-favicon-refresh

bkoopman commented 8 years ago

Not really sure about the use of the querystring there, that seems to make the browser load the favicon every request, which seems like needles overhead. But Agree that we should add the link tag for the favicon to the header indeed.

paceaux commented 8 years ago

The querystring was a typo, that's not necessary. Sorry about that.

rpannekoek commented 8 years ago

TSI-1948 (internal issue ID for tracking purposes)