Null check and speed optimizations

RWS / dxa-web-application-dotnet

SDL Digital Experience Accelerator .NET MVC web application

Apache License 2.0

19 stars 34 forks source link

Null check and speed optimizations #71

Closed ronnqvistandreas closed 5 years ago

ronnqvistandreas commented 5 years ago

Null check coreResources when post processing page title

Without this, the application may crash in rare circumstances when core resources are not available.

Return empty MvcString for DxaRegionMarkup, DxaEntityMarkup and DxaPropertyMarkup when not in Preview mode

Page render may is improved when not computing MemberExpression. In Live environments, it would always compute even though nothing should be rendered.

rpannekoek commented 5 years ago

Note tha DxaEntityMarkup and DxaPropertyMarkup is not only used for generating XPM markup, but also for semantic markup (RDFa). So, disabling those completely on Live in general is too aggressive; that approach only works if you are not using public semantics (for SEO purposes) in your implementation.

ronnqvistandreas commented 5 years ago

I was not aware of that. Would it be possible to check if the entity has any public semantics in order to reduce the aggressiveness?