search

RWS / dxa-web-application-java

SDL Digital Experience Accelerator Java Spring MVC web application
25 stars 37 forks source link

Function parameter not used, but logging/Exception says otherwise #131

Open DominicCronin opened 4 years ago

DominicCronin commented 4 years ago

https://github.com/sdl/dxa-web-application-java/blob/05cb742c88d819310ee029702f440ee2ecf45c4d/dxa-framework/dxa-common-api/src/main/java/com/sdl/webapp/common/controller/BaseController.java#L67

In getEntityFromRequest, the entityId parameter only gets used in what is then presumably a misleading log message and Exception

The same pattern is also to be seen in getRegionFromRequest