Open PGorzalka opened 3 years ago
@PGorzalka: Are you working or intend to work on this issue yourself? Otherwise, we will discuss it on hackday.
@DaJansenGit already received some code from me that I intended to contribute here later this month. If he doesn't object, I think that would cover the issue.
@DaJansenGit @PGorzalka What is the current status of this issue?
@tobinfiedler @DaJansenGit sorry I didn't come back to this; had other projects I was working on. However, as my PhD exam approaches it would be nice to have the code I wrote as part of the PhD project finally contributed here. That's the code mentioned in May last year. It covers several other topics, but this one could be a good starting point for the contribution. As it requires some extra work from my side (my fork of AixLib is pretty old): How urgently do you need it?
The long delay here is on me. I still need to give your models a detailed look @PGorzalka. But since the review is also a more comprehensive change, it's still on my list. Maybe we can schedule a meeting in December to discuss the next steps? I will then have a look at the changes beforehand. Hard deadlines usually help at least on my side 😆
Any updates on this? @DaJansenGit @PGorzalka
@FelixStege not yet. @DaJansenGit didn't manage to schedule a meeting last year... If you're working on the topic, maybe we could arrange one together? My PhD thesis was delayed by RWTH-internal issues, but hopefully finish with the exam this year. So I still got the motivation mentioned above.
@PGorzalka and I had a discussion about the changes that makes sense. Following you can find the results.
ThermalZone
addNZsAndSoil
will be not implemented in this issuezoneParam
(not including weather file option)
amplitude
for sinus curveoffset
(but this might also be fixed)This was closed due a merge into IPBSA (https://github.com/ibpsa/modelica-ibpsa/pull/1790)
We will keep this open until the next IBPSA merge is done.
What is the problem?
How do we want to solve it? Describe the solution you'd like
Additional context
This issue is related to a case-specific application of AixLib (ROM) and TEASER which also includes issue #679 in TEASER (others may follow after email consultations)