RWTH-EBC / AixLib

A Modelica model library for building performance simulations
https://ebc-tools.eonerc.rwth-aachen.de/aixlib
174 stars 81 forks source link

HeatPumpSystem fails to check in OpenModelica #1347

Open FWuellhorst opened 1 year ago

FWuellhorst commented 1 year ago

Describe the bug The models in the package `` fail in OpenModelica.

Error log

 Error in model:  AixLib.Systems.HeatPumpSystems.BaseClasses.HPSystemController 
[D:/04_git/AixLib/AixLib/Controls/SetPoints/Functions/HeatingCurveFunction.mo:7:3-8:78:writable] Error: Invalid public variable TDesign, function variables that are not input/output must be protected.

 Error in model:  AixLib.Systems.HeatPumpSystems.BaseClasses.PartialHeatPumpSystem 
[D:/04_git/AixLib/AixLib/Controls/SetPoints/Functions/HeatingCurveFunction.mo:7:3-8:78:writable] Error: Invalid public variable TDesign, function variables that are not input/output must be protected.

 Error in model:  AixLib.Systems.HeatPumpSystems.Examples.HeatPumpSystem 
[D:/04_git/AixLib/AixLib/Controls/SetPoints/Functions/HeatingCurveFunction.mo:7:3-8:78:writable] Error: Invalid public variable TDesign, function variables that are not input/output must be protected.

 Error in model:  AixLib.Systems.HeatPumpSystems.HeatPumpSystem 
[D:/04_git/AixLib/AixLib/Controls/SetPoints/Functions/HeatingCurveFunction.mo:7:3-8:78:writable] Error: Invalid public variable TDesign, function variables that are not input/output must be protected.
FWuellhorst commented 3 weeks ago

This will be closed by #1520 as HeatPumpSystem is now obsolete.