RWTH-EBC / AixLib

A Modelica model library for building performance simulations
https://ebc-tools.eonerc.rwth-aachen.de/aixlib
175 stars 81 forks source link

Moved the connector from AixLib.ThermalZones.HighOrder.Rooms.BaseClasses.PartialRoomParams to .PartialRoom #1522

Closed TobiasSpratte closed 2 months ago

TobiasSpratte commented 2 months ago

Removed the connector from AixLib.ThermalZones.HighOrder.Rooms.BaseClasses.PartialRoomParams, because it should only contain parameters, and added the connector to AixLib.ThermalZones.HighOrder.Rooms.BaseClasses.PartialRoom.

TobiasSpratte commented 2 months ago

This closes #1401.

ebc-aixlib-bot commented 2 months ago

Thank you for making a Pull Request to AixLib!

Our CI pipeline will help you finalize your contribution. Here's what is typically checked:

If HTML errors occur, I will fix the issues using a separate pull request. For the other checks, I will post the results here: https://rwth-ebc.github.io/AixLib/1401-improve-parameterization-in-highorder-model/index.html

Tips to fix possible naming violations:

If all CI stages pass and you have addressed possible naming violations, please consider the following:

Once you have addressed these points, you can assign a reviewer. Although this process may seem tedious, ensuring CI passes allows the reviewer to focus their time on the actual modeling rather than syntax and unintended breakages caused by your changes.

If you have any questions or issues, please tag a library developer. Once again, thank you for your valuable contribution!