search

RWTH-EBC / AixLib

A Modelica model library for building performance simulations
https://ebc-tools.eonerc.rwth-aachen.de/aixlib
177 stars 82 forks source link

Change "AOI" to "incAng" for naming convention #1524

Open TobiasSpratte opened 3 months ago

TobiasSpratte commented 3 months ago

In the ThermalZones.HighOrder models and in some other models like AixLib.Utilities.Sources.PrescribedSolarRad, "AOI" is used as the name for the incidence angle. In the IBPSA models, "inc" or "incAng" is used. I suggest to also use "incAng" instead of "AOI".

Yugalgarg2002 commented 3 months ago

I am willing to take up this issue, please assign it to me.

TobiasSpratte commented 3 months ago

Thank you for your support! After a discussion on this topic, the name "incAng" would be more appropriate. Would you also make this change?

Yugalgarg2002 commented 3 months ago

Sure, I will take it up, assign it to me.