search

RWTH-EBC / AixLib

A Modelica model library for building performance simulations
https://ebc-tools.eonerc.rwth-aachen.de/aixlib
178 stars 82 forks source link

HeatPump turns singular without modeSet input through Bus even if not reversible #1531

Closed Mov0 closed 2 months ago

Mov0 commented 3 months ago

Describe the bug A heat pump based on AixLib.Fluid.HeatPumps.HeatPump that only supports heating mode (useRev=false) and is not connected through the bus connector (useBusConnectorOnly=false) will turn structurally singular. Though the connector for modeSet disappears correctly, when useRev is set to false and the heat pump only supports heating mode, modeSet does not seem to be set to true (for heating mode) internally. This results in the requirement to manually set modeSet to true through the bus connector, which should not be necessary.

To Reproduce Steps to reproduce the behavior:

  1. Copy AixLib.Fluid.HeatPumps.Examples.HeatPump
  2. Switch useRev in heatPump to false. Delete booleanSwitch, hysCooling, logicalSwitch and not2, essentially simplifying the example to match a heat pump that is only capable of heating. See Screenshots.
  3. Check the model
  4. See error

Expected behavior The model should not require modeSet to be assigned a value thorugh the bus connector

Screenshots This is structurally singular: Screenshot 2024-08-14 160819 While this is working: Screenshot 2024-08-14 160757

Desktop Dymola2023x with Modelica 4.0.0 on Windows 10 22H2

FWuellhorst commented 3 months ago

That is true, thanks for raising this issue. I am currently in the process of moving the heat pump models to Obsolete #1520 . I will fix it when moving the models, but I would just advise to use the new models.