search

RWTH-EBC / AixLib

A Modelica model library for building performance simulations
https://ebc-tools.eonerc.rwth-aachen.de/aixlib
177 stars 82 forks source link

AixLib.Fluid.HeatExchangers.Radiators.BaseClasses.RadiatorTypes is declared twice causing radiator simulations to fail in Open Modelica Connection Editor #1535

Closed HenryDore closed 1 month ago

HenryDore commented 2 months ago

Describe the bug AixLib.Fluid.HeatExchangers.Radiators.BaseClasses.RadiatorTypes is declared twice causing radiator simulations to fail

To Reproduce Steps to reproduce the behavior:

  1. Load AixLib 2.0.0 in OpenModelica connection editor
  2. Load example AixLib.Fluid.HeatExchangers.Radiators.Examples.Radiator or
  3. Simulate example
  4. See error class already declared

Commit 27df055 "Changed RadiatorTypes from package to .mo File, to eliminate error when opening in OpenModelica" failed to remove directory RadiatorTypes so class gets redeclared, also need to remove duplicate RadiatorTypes line in package.order to fix.

FWuellhorst commented 1 month ago

@HenryDore : PR #1536 fixes this issue, thanks for reporting it. It worked for me locally in OM, can you check if it works for you, as well?

HenryDore commented 1 month ago

Can confirm it is working for me in OM also 👍 thanks!