search

RWTH-EBC / AixLib

A Modelica model library for building performance simulations
https://ebc-tools.eonerc.rwth-aachen.de/aixlib
178 stars 82 forks source link

ROM simulation fails for a zone without windows #1545

Open PGorzalka opened 1 week ago

PGorzalka commented 1 week ago

If a TEASER model with no window area is exported to AixLib, simulation fails due eqAirTempWall.sunblind not being connected from the outside in ThermalZone. The reason is that eqAirTempWall is conditional to (sum(zoneParam.AExt) + sum(zoneParam.AWin)) > 0, but the input from simpleExternalShading is conditional to sum(zoneParam.ATransparent) > 0.

I suggest removing the conditionality of simpleExternalShading and corGMod in AixLib.ThermalZones.ReducedOrder.ThermalZone.ThermalZone.

DaJansenGit commented 3 days ago

Hey @PGorzalka, thanks for posting this issue.

Your approach would work, but wouldn't it be more elegant to make the input sunblind conditional based on sum(zoneParam.ATransparent) > 0 as well in AixLib.ThermalZones.ReducedOrder.EquivalentAirTemperature.BaseClasses.PartialVDI6007? In this case the following equation in the model also needs to be conditional:

TEqWin=TDryBul.+delTEqLWWin*(ones(n)-sunblind);

Maybe I'm missing something?