search

RWTH-EBC / BESMod

A Modelica library providing building energy system modules
Other
17 stars 0 forks source link

Minor bug fixes #68

Closed LauraMaier closed 7 months ago

LauraMaier commented 1 year ago

This list contains a collection of minor bug fixes. The list is constantly growing and will be addressed in January

1. DHW error even though no DHW subsystem Bug: When selecting use_dhw = false and redeclare BESMod.Systems.Demand.DHW.TappingProfiles.calcmFlowEquDynamic calcmFlow, the model has an error even though DHW is not supposed to be used.

Model error - division by zero: (DHW.calcmFlow.division.u1) / (DHW.calcmFlow.division.u2) = (0) / (0)

Error: could not solve simplified initialization for homotopy method. Error: Integrator failed to start model.

Suggested solution: Add option for calcmFlow option for "no_DHW" or add "no_DHW" as selectable subsystem

2. Misleading model names Bug: All controllers in BESMod.Systems.Hydraulical.Control.Components.HeatPumpNSetController are referred to heat pumps but they are also suitable for boilers, etc.

Suggested solution: Use more general names for models and packages

github-actions[bot] commented 1 year ago

Branch issue-68-Minor_bug_fixes created!

FWuellhorst commented 7 months ago
  1. Should be fixed, I added an example BESMod.Examples.DesignOptimization.BESNoDHW to demonstrate how to simulate without dhw.
  2. Renamed to BESMod.Systems.Hydraulical.Control.Components.RelativeSpeedController in latest release