search

RWTH-EBC / FiLiP

FIWARE Library for Python (FiLiP) to work with FIWARE API
BSD 3-Clause "New" or "Revised" License
23 stars 13 forks source link

fix: remove exclude_defaults #229

Closed tstorek closed 8 months ago

tstorek commented 10 months ago

closes #228

tstorek commented 10 months ago

@djs0109 unfortunetaly, I cannot see, where the pipeline fails. Please, let me know, what the problem is :)

djs0109 commented 10 months ago

@tstorek I just marked all the places where the exclude_unset is also removed. Did you have some criteria for removing or not removing the exclude_unset?

tstorek commented 10 months ago

@djs0109 I explained above why I think that it is better to also exclude unset. This only means taht all basic filip models must use None as default, if they should not be sent by default. Sound reasonable? Do the tests work now?

djs0109 commented 10 months ago

@tstorek It sounds reasonable. But for the consistency, do you think it is better to remove all exclude_unset? Btw, the tests can run through now.

tstorek commented 10 months ago

@djs0109 i removed them wherever it was safe at the first glance. Probably for consistency it would be good to remove them all. Please, feel free to check. :) thank you

djs0109 commented 9 months ago

@tstorek I remove all exclude_unset for consistency. And I think this is actually better in the case of NGSI endpoints changing certain behaviors, such as changing the previous default value. If all tests run through, I will merge this PR. What do you think?