search

RWTH-EBC / FiLiP

FIWARE Library for Python (FiLiP) to work with FIWARE API
BSD 3-Clause "New" or "Revised" License
23 stars 13 forks source link

Adding new attributes to the HttpCustom model #295

Closed RCX112 closed 2 months ago

RCX112 commented 2 months ago

Extended the pydantic model with the attributes json, ngsi and timeout. Also added some tests for the pydantic model.

djs0109 commented 2 months ago

@RCX112 I think there might be some misunderstanding. The related issue #290 should actually add headers under httpCustom. The related docs are here. I am really sorry for that. The implementation here is partially duplicated with #288, I am now looking into it and will see whether we can merge the two branch

djs0109 commented 2 months ago

OK, I get it now. The headers already exists

djs0109 commented 2 months ago

@RCX112 I will then merge #290 to #288 and then close the #290 . What do you think?

RCX112 commented 2 months ago

@djs0109 Sorry for the misunderstanding, we discussed this problem also in yesterday's meeting. I think merging both branches is a good idea

djs0109 commented 2 months ago

Close, because it is merged to #288