RWTH-EBC / TEASER

TEASER - Tool for Energy Analysis and Simulation for Efficient Retrofit
Other
115 stars 65 forks source link

Dependency of multizone parameters to zone records #573

Open PMehrfeld opened 5 years ago

PMehrfeld commented 5 years ago

What is the problem?

Why do we want to solve it?

How do we want to solve it?

This is just a suggestion.

mlauster commented 5 years ago

Nice suggestion, but won't work since these parameters are defined in records and the current Modelica compiler can't handle such dependencies. But I'm not sure for what you need ABuilding, could be just for information or for calculation of ventilation rates

PMehrfeld commented 5 years ago

At least for ABuilding it works (I have only a one zone model currently). I don't know, where this parameter is used. In the whole AixLib I found it only in the examples and in its declaration in PartialMultizone. However, it seems as it is not passed through at any point. I didn't check the other two parameter @MichaMans: Do you maybe know more about this?

Anyway, my solution works in my simulation setup: image

MichaMans commented 5 years ago

@PMehrfeld I'm fine with your solution if it works. But does it make sense only changing the zone area without effecting the other parameters? Because with a changed zone area, whether the wall areas needs to change too, or they were initially false? Or do i miss something here?

PMehrfeld commented 5 years ago

Yes, there remain interdependencies within the zone record. This was just a suggestion for the class one level higher. E.g. you change in the drop down the zoneParam record(s), you don't need to adapt the 3 parameters above. Furthermore, you could use numZones = size(zoneParam, 1).

It is no magic or really important thing. Just a suggestion to print the dependency string (as long as there exist a clear dependency) instead of writing the value ;)

MichaMans commented 5 years ago

Sounds good for me!

mlauster commented 5 years ago

Did you check in pedantic mode and with a multizone setup? If this works, I am also fine.

PMehrfeld commented 5 years ago

Yes, it checked in pedantic mode with 2 zones.

mlauster commented 5 years ago

Crazy, ok, then I allow it! :-)