search

RWTH-EBC / richardsonpy

Python version of Richardson tool
GNU General Public License v3.0
17 stars 5 forks source link

timestepElectricalLoad #9

Closed mschumacher247 closed 6 years ago

mschumacher247 commented 6 years ago

Generation of ElectricalLoad instance with timestep different from 3600 doesn't work properly. Can be fixed by implementing additional timestep_try for test reference year resolution.

JSchiefelbein commented 6 years ago

@mschumacher247 Just to understand, what you would like to achieve: Do you want to generate electric load profiles in another resolution than 60 seconds? Then you should use the change_resolution function. If you change the timestep within electric_load, you are also going to change the dynamic profile of the electric load, as the datasets are 'made' for 60 second timesteps. We should probably remove the timestep parameter as input parameter to prevent modification and fix 60 seconds as timestep.

JSchiefelbein commented 6 years ago

Well, I separated the different timesteps and added a user defined timestep just for profile rescaling. Hopefully this is going to help

mschumacher247 commented 6 years ago

@JSchiefelbein Yes that is what I was looking for. I wasn't aware that the timestep for the electric load profile generation needs to be fixed at 60s. I will have a look at your proposed solution.