RaJiska / terraform-aws-fck-nat

Terraform module for fck-nat
https://registry.terraform.io/modules/RaJiska/fck-nat/aws/latest
MIT License
74 stars 39 forks source link

Don't fail if the instance type architecture is not arm64 #22

Closed alexbakker closed 5 months ago

alexbakker commented 5 months ago

The regex function raises an error in case there's no match, so use regexall instead and check the number of matches.

Fixes #7.

RaJiska commented 5 months ago

Which case is this fixing? I believe this has been solved with merge https://github.com/RaJiska/terraform-aws-fck-nat/commit/d30df5222accaa2d8a17cf74826f912899d4d265.

alexbakker commented 5 months ago

You're right. I used a release version of the module, ran into the issue, then enthusiastically started fixing it, somehow missing that this was already fixed in the master branch.

My bad. Thanks for terraform-aws-fck-nat btw!