search

RaJiska / terraform-aws-fck-nat

Terraform module for fck-nat
https://registry.terraform.io/modules/RaJiska/fck-nat/aws/latest
MIT License
74 stars 39 forks source link

Add support for fck-nat v1.3.0 #30

Closed chan-vince closed 4 months ago

chan-vince commented 4 months ago

The versions later than v1.2.1 have a new AMI naming scheme, to reflect that they're now based on Amazon Linux 2023.

This PR updates the data block which fetches the latest AMI, so that if you don't specify a specific AMI and are just happy with the latest one, then the new AMI will be found.

image

As above, the images are now called fck-nat-al2023-hvm-1.3.0-20240125-arm64-ebs, which are filtered out from the old filter of fck-nat-al2023-hvm-*.

There are other features in 1.3.0 which sound like they also need corresponding Terraform changes to support, but I have not looked into that here.

RaJiska commented 4 months ago

Could you describe how fck-nat-al2023-hvm-* is not matching the fck-nat-al2023-hvm-1.3.0-20240125-arm64-ebs pattern? I'm having troubles understanding this part. It should already be getting you the latest fck-nat AL2023 image.

Furthermore your change would end up matching any non-AL2023 images as well.

chan-vince commented 4 months ago

Ah crap I was looking at an old module in my .terraform folder, and I should have had a coffee before making this. Apologies for wasting your time!

RaJiska commented 4 months ago

No worries and thank you, the intention matters! :)