search

Raagh / angular-karma_test-explorer

vscode extension for easy angular testing and debugging
https://marketplace.visualstudio.com/items?itemName=raagh.angular-karma-test-explorer
MIT License
65 stars 23 forks source link

Improved error handling for Karma Launcher child process #103

Closed s4m0r4m4 closed 3 years ago

s4m0r4m4 commented 3 years ago

I was running into some issues where the tests never loaded, but no errors were seen from the child process that launched karma. Turns out there were some errors coming from the process, but they were not being handled. I tried to make sure that we're now catching and showing all errors in the log so that folks can see what's breaking easier.

s4m0r4m4 commented 3 years ago

All tests passed when I ran rpm run test

Raagh commented 3 years ago

@s4m0r4m4 is this still valid? if so please update the version in package.json and changelog. Since you are now a contributor to the project no need to keep submitting pr for my approval 😄

s4m0r4m4 commented 3 years ago

Thanks for checking! I made a few more changes on a different branch that I'll just merge in all together, see #104.