Raagh / angular-karma_test-explorer

vscode extension for easy angular testing and debugging
https://marketplace.visualstudio.com/items?itemName=raagh.angular-karma-test-explorer
MIT License
65 stars 23 forks source link

How to get this working with ng and nx (monorepo)/ng #74

Closed craigryan closed 4 years ago

craigryan commented 4 years ago

Ask the question Does this extension work without Jasmine Test Explorer? With a fresh angular app it doesn't show any tests when enabled, but does when I also enable Jasmine Test Explorer extension. Similarly if I disable your extension then jasmine test explorer doesn't work on its own and shows a blank explorer.

Another question: when I setup an Nx / Angular + karma project (monorepo) no matter what I do the extension does not find any tests. Is this setup unsupported? If so do you plan on making it compatible with Nx?

Good effort, thanks for sharing this extension!

Additional context

Raagh commented 4 years ago

Hey, @craigryan thank you for commenting, no this project should not depend on jasmine test explorer. the only dependencies that this project has are the Test Explorer UI and the Debugger for chrome. Did you restart vscode between installs of the jasmine test explorer?

No, at the moment this project does not support Nx. Luckily, after months of only doing backend, I am back on working full time with Angular, and at my current job we are moving to Nx, so I will back improving this and probably adding support for Nx in the future.

craigryan commented 4 years ago

Sorry I had no idea you replied in March! I must of missed a notification email? Anyway, good to hear you're planning to look into Nx - this is the main reason some of our team move to IntelliJ just so the debug/testing is as easy as with Java. So I look forward to any Nx updates!

thanks again Craig

On Wed, Mar 25, 2020 at 12:54 AM Patricio Ferraggi notifications@github.com wrote:

Hey, @craigryan https://github.com/craigryan thank you for commenting, no this project should not depend on jasmine test explorer. the only dependencies that this project has are the Test Explorer UI and the Debugger for chrome. Did you restart vscode between installs of the jasmine test explorer?

No, at the moment this project does not support Nx. Luckily, after months of only doing backend, I am back on working full time with Angular, and at my current job we are moving to Nx, so I will back improving this and probably adding support for Nx in the future.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Raagh/angular-karma_test-explorer/issues/74#issuecomment-603252110, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6DNLXEPM4TNTFHOF2ATH3RJC3P3ANCNFSM4LSLFXBQ .

s4m0r4m4 commented 4 years ago

+1 for nx support, that would be awesome! Should a separate feature request be created for that? Just so those of us interested in Nx support can track when its available?

the-ult commented 4 years ago

@Raagh , does it work with NX projects?

The Test Explorer keeps loading.. And does not show/load the tests.