search

Raagh / angular-karma_test-explorer

vscode extension for easy angular testing and debugging
https://marketplace.visualstudio.com/items?itemName=raagh.angular-karma-test-explorer
MIT License
65 stars 23 forks source link

Tests are discovered but Code Lens and Show Source buttons are not displayed #89

Closed lucono closed 2 years ago

lucono commented 4 years ago

Ask the question I am using the Angular/Karma Test Explorer extension in a Karma-only project for which the extension works great and discovers the tests, listing them in the Test panel, except that the Show source icon which would normally appear next to each discovered test for navigating to the test location in the actual test files are not present, and there are also no code lens links above the tests in the test files. On investigating, I believe it is not detecting the line number locations of the the discovered tests, causing the code lens and the navigation buttons not to be shown.

Thanks.

hugoblanc commented 4 years ago

You can get more informations about the error which is stucking the test explorer thread by using the angularKarmaTestExplorer.debugMode: true in VSCode settings and looking into the extension output "Test explorer log"

s4m0r4m4 commented 3 years ago

Hi @lucono , we just released v1.2.8. Once you've upgraded to that version (should happen automatically in VS Code), please try again and check the output window for the test logs. This new version has some additional error handling that may show you what the issue is. It also shows the command used to launch the karma process (ng test for example), which may provide additional insight into what's going wrong here.

s4m0r4m4 commented 3 years ago

@lucono is this still an issue?

lucono commented 3 years ago

@s4m0r4m4 I haven't used this in a while. I've been using a local fork with various fixes/updates I needed at the time last year, and have made some attempt recently to port those back into this project after it started accepting contributions again, but without much success as it's diverged quite significantly.

s4m0r4m4 commented 3 years ago

Ok sounds good. Yes I'm very open to accepting new PRs and would welcome your contribution, feel free to open a draft PR if you'd like to discuss any specific changes.

lucono commented 3 years ago

@s4m0r4m4 With the significant divergence and without much success porting the changes back to this project, I've taken some time since our conversation above to document it, add more tests, and have just published it to the marketplace as a new extension that's based on this extension.

s4m0r4m4 commented 3 years ago

Sounds good, thanks for letting us know. The original author and I no longer use karma so we're going to start pointing people to your repo, as we don't plan to maintain this one going forward (although it would have been nice to continue using the same repo so people can easily update to the new version, please let me know if you'd consider merging your changes into this repo given our update here).

lucono commented 2 years ago

Thanks @s4m0r4m4. What I think would make sense is to keep the Angular/Karma Test Explorer project, and put it in maintenance mode if no longer developing it, while potentially letting users know of the new extension so they can try it at their convenience without disruption to their use of the current extension.

s4m0r4m4 commented 2 years ago

Ok! I will start directing folks to try your plugin. I also thought I found a way to officially deprecate an extension and point to a recommended replacement, but I can't find any info on how to do that (other than putting the word "deprecated" in the title). Let me know if you know how to do that and I'd be happy to make it happen.