RaananW / PhoneGap-Image-Resizer

Providing an image resizer plugin for phonegap projects on both Android and iOS
93 stars 89 forks source link

Cordova 2.1.0 conversion? #1

Closed inator closed 10 years ago

inator commented 11 years ago

This seems like a great plugin, which I could desperately use for iOS and Android - but need to update for Cordova 2.1.0 use. I can help, but I'm not well versed in plugin development. Would you consider giving the conversion a shot?

RaananW commented 11 years ago

Hi, I sadly couldn't find the time so far to update it. It shouldn't be a big issue, I guess. Will do my best to find the time next week to go over the code and see how to make it more Cordova 2 conform.

RaananW commented 11 years ago

Hi Inator,

checked the documentation. The changes were not too hard to implement, so i updated the javascript and the Android Plugin. Sadly i don't currently have a mac around to test the iOS version, so it will have to wait (or, if you wish, you can fork it and send me a pull request). I am leaving this open until i will update the iOS version.

I just tested the plugin using cordova 2.1.0 and it worked great.

lukeholder commented 11 years ago

would love to see it updated for ios

RaananW commented 11 years ago

Still haven't found the time to finish the iOS version, will do it soon :)

cuebit commented 11 years ago

I concur with @lukeholder, would love to see some progress on this. This is currently the only viable solution that exists and it's a massive shame it's not in sync with the latest Cordova project.

RaananW commented 11 years ago

There must be a mac around here.. :) I am currently a bit occupied with other projects, i do know it shouldn't be too hard to change. If someone had the time to debug it and send me a pull request, it would also be great.

RaananW commented 11 years ago

Android and iOS were updated, the JavaScript stays the same :-) I have only tested the iOS version on the simulator. I am leaving the issue open and will close it if no one comes back with a serious error.

lukeholder commented 10 years ago

thanks @raananw !