search

RabbitHoleEscapeR1 / r1_escape

343 stars 34 forks source link

Solve Debian issues #40

Open MaGaroo opened 4 months ago

MaGaroo commented 4 months ago

Hey. There were three problems:

  1. virtualenv didn't setup correctly in my Ubuntu 22.04. There was no file as venv/bin/activate
  2. Python virtualenv isn't used while using sudo. Someone tried to resolve it in #21 , but I think it was really nasty and my approach is better.
  3. If a step fails, script continues. It's ridiculous and it must not!!

Feel free to give feedback. Feel free to reject PR. Whatever you prefer. :joy:

AgentFabulous commented 4 months ago

I agree, I like your approach better, however we must keep in mind that sudo is not necessary to run mtkclient on Linux. Can’t this be a wrapper on invoking the script, or similar?