search

RabbitHouseCorp / ChinoKafuu

🐰 | An incredible bot which can help you in your daily routine in your guild whenever you need it.
GNU Affero General Public License v3.0
60 stars 14 forks source link

Anime search spell check #269

Closed aReebok closed 2 years ago

aReebok commented 2 years ago

Hi! I was interested in contributing to the AnimuCommand.js because while using the bot in my server, I noticed that when I typed in "aot" it returned something that wasn't related to attach on titans. Additionally minor spelling errors result in different outputs or no outputs at all. I'd like to add a simple spell checker but I wasn't able to get the bot up in deployment mode. I've added a spell checker on my own personal bot before, and it's very convenient.

I could just test it on my own bot and then add that spell checking piece of code to this bot and start a pull request. Otherwise I'm available to get in contact with someone to help me get the bot open in dev mode! I'd love to add to this, so please let me know!

DanielaGC commented 2 years ago

Hi, aReebok! Actually, the AnimuCommand.js doesn't make a search, this command is used to play the Animu Radio https://animu.com.br, if you wanna search for an anime, use /anime aka AnimeCommand.js

aReebok commented 2 years ago

Oh right I got confused. I was referring to the /anime command from AnimeCommand.js. It uses the mal-scraper which doesn't check for abbreviations sometimes or for spelling mistake. I think it would be cool to add a few lines to make the search better.

nayvcake commented 2 years ago

Hi, You say search the name of the anime or result found on the page?

aReebok commented 2 years ago

Hi, You say search the name of the anime or result found on the page?

Hello ty for ur message, though I'm not sure I understand.

To be more clear, when you do something like:

/anime name: aot

It doesn't respond with info on Attack On Titan but on something else that's not even related to the "aot" search term. Surprisingly, it returns correct info if you put in "dbz" for dragon ball z.

Same with miss spelling. Putting in "debth note" will not return information on "death note" and will give that the search term wasn't found.

I had this issue with my movie scraper for my tutorial bot.

All we'd need to do would be send a request to google and then scrape the actual correctly spelled name and then pass it to the mal-scraper. For example if you type "anime aot" on google, you instantly get the real title: "attack on titan." Similar to when you type "anime debth note," we can scrape the actual title or something. I can send a pull req maybe but forking it and setting it up minimally to get the job done is proving to be difficult, so I'm not able to test my code. But it's a few lines so I can do a pull req and someone can try it out? 👀

nayvcake commented 2 years ago

Updating There's been a change we can't do anything about it. Unless creating an issue on github to solve in mal-scrapper

DanielaGC commented 2 years ago

This issue will be closed due to this problem is not our responsability.