Rabbitminers / Extended-Cogwheels

[Forge & Fabric, 1.18.2, 1.19.2 & 1.20.1] Adding more cogwheels to the create mod aswell as providing progression systems to modpack developers through configurations
https://modrinth.com/mod/extended-cogwheels
MIT License
8 stars 18 forks source link

Implementing new cogwheel materials through datapacks #25

Closed Octelly closed 1 year ago

Octelly commented 1 year ago

I'm not that familiar with Java, but from what I can see, the cogwheel materials are currently hardcoded: https://github.com/Rabbitminers/Extended-Cogwheels/blob/df0728a7a8e3e0df79bbe80bea0299a537b335d0/common/src/main/java/com/rabbitminers/extendedgears/base/data/WoodenCogwheel.java#L14-L22

I think it would be really cool, if the mod automatically generated the cogwheel items based on datapack information, the same you do recipes. ( https://github.com/Rabbitminers/Extended-Cogwheels/tree/df0728a7a8e3e0df79bbe80bea0299a537b335d0/common/src/main/resources )

Rabbitminers commented 1 year ago

Datapacks cannot load assets, perhaps kubejs or craft tweaker integration could be explored