Rabbitminers / Extended-Cogwheels

[Forge & Fabric, 1.18.2, 1.19.2 & 1.20.1] Adding more cogwheels to the create mod aswell as providing progression systems to modpack developers through configurations
https://modrinth.com/mod/extended-cogwheels
MIT License
8 stars 18 forks source link

Several modded wood types don't look right when applies to cogwheels #68

Open saltyseadoggo opened 1 year ago

saltyseadoggo commented 1 year ago

Describe the bug Several modded wood types don't look right when you apply them to cogwheels. Cogwheels with these wood types applied use oak log/plank textures instead of the given wood type's textures. The wood types I found have this issue are as follows:

BYG

Regions Unexplored

Ars Nouveau

The common thread with these wood types seems to be that they either lack a stripped log/stem, or the stripped log/stem has an id with an unexpected format.

To Reproduce Steps to reproduce the behavior: 1: Start the game with Create, C:Extended Cogwheels and any of the above mods loaded. 2: Place any cogwheel. 3: Obtain any of the plank items mentioned above. 4: Right click the cog while holding the plank.

Expected behavior The cogwheel would take on an appearance matching the plank I used on it, as it would for all other wood types.

Screenshots The errored archwood cog. All of the cogs with this issue look like this. 2023-09-21_21 47 46

Loader & Other Mods:

StormDragon-64 commented 1 year ago

Ecologics flowering acacia planks also have this issue. Create’s waterwheels display these wood types just fine, and this issue affects all cogwheel types (large, shaftless, etc.) btw.

Rabbitminers commented 1 year ago

The common thread with these wood types seems to be that they either lack a stripped log/stem, or the stripped log/stem has an id with an unexpected format.

Yep that's exactly it, we use the stripped texture of a log as it tends to be the smoothest. There's not much we can do about it if that texture can't be found. Unless you have any suggestions we could either leave it as it is and default the textures, pop up a message saying the wood types can't be used or try and fall back on a different texture, say the plank

saltyseadoggo commented 1 year ago

i do have a suggestion, actually: perhaps add a config where end users can manually specify what textures to use for a cog that has had a given plank type applied here's an example to show what the formatting could look like

{
  "regions_unexplored:sculkwood_planks": {
    "top": "regions_unexplored:sculkwood_log_dark_top",
    "side": "regions_unexplored:sculkwood_log_dark"
  }
}
Rabbitminers commented 1 year ago

Interesting, we could definitely do something like that although it would probably work better being in data packs rather than in config

saltyseadoggo commented 1 year ago

sounds good to me~

Rabbitminers commented 1 year ago

Can you send me the ids of the stripped logs you would expect to be used in these cases

saltyseadoggo commented 1 year ago

sure~

BYG

Regions Unexplored

Ars Nouveau