search

Rabbitminers / Extended-Cogwheels

[Forge & Fabric, 1.18.2, 1.19.2 & 1.20.1] Adding more cogwheels to the create mod aswell as providing progression systems to modpack developers through configurations
https://modrinth.com/mod/extended-cogwheels
MIT License
8 stars 18 forks source link

[Mod Enhancement] Adding support for TFC #97

Open Xelbayria opened 2 months ago

Xelbayria commented 2 months ago

Take a look at the DynamicCogWheelRenderer.java#L81. If I understand the code correctly, that should be how the wheel render itself using the texture of a _log or stem. The ID is `modID:stripped_log`

TerraFirmaCraft's ID for woods IIRC is tfc:wood/oak_log or tfc:wood/log/oak (I'll check and update)

Let me know if you want me to make PR

Rabbitminers commented 2 months ago

Take a look at the DynamicCogWheelRenderer.java#L81. If I understand the code correctly, that should be how the wheel render itself using the texture of a _log or stem. The ID is modID:stripped_log

Yep, this is re-used from how create generates textures for water wheels. Seems like they've added compatibility for TFC like so. We could probably use a very similar implementation. I'd be happy to add this myself when I've got some time but you're welcome to open a PR if you'd prefer :)

Xelbayria commented 2 months ago

👍🏻 Let me know if you need me to make PR

Rabbitminers commented 2 months ago

Im not sure when I'll next be able to get round to working on this, might be about a little bit so if you've got the time and dont mind a PR would be great. I'll and get the changes released asap

Xelbayria commented 2 months ago

Alright, I should be able to create PR tomorrow.