Rabby returns "User Cancel" when a Gnosis Safe transaction is successfully queued

RabbyHub / Rabby

The game-changing wallet for Ethereum and all EVM chains

https://rabby.io

Other

1.33k stars 373 forks source link

Rabby returns "User Cancel" when a Gnosis Safe transaction is successfully queued #2250

Open danaugrs opened 3 months ago

danaugrs commented 3 months ago

Hi!

Rabby is returning "User Cancel" when a Gnosis Safe transaction is successfully queued. Can this be fixed? I think this is coming from: https://github.com/RabbyHub/Rabby/blob/ff7cfc8afb05a73a031d836447ed873c3afeb8f0/src/background/service/notification.ts#L194

Thanks!

vvvvvv1vvvvvv commented 3 months ago

Since there is no tx hash when safe transaction queued, we can't tell dapp this transaction is completed without tx hash, so the workaround is return an Error message