RabbyHub / Rabby

The game-changing wallet for Ethereum and all EVM chains
https://rabby.io
Other
1.35k stars 379 forks source link

Unable to add custom RPC with the same chainID #2276

Open 0xGitGuy opened 4 months ago

0xGitGuy commented 4 months ago

This issue was somewhat discuss before https://github.com/RabbyHub/Rabby/issues/261

I get an error when attempting to add a second RPC for ethereum.

The error: Chain already integrated by Rabby Wallet

Why can we only have one RPC per chain? Metamask supports multiple RPC for the same chain. This is not only useful for dev work but also as a quick backup for switching between RPC provider.

0xGitGuy commented 4 months ago

"Modify RPC URL" feature is not a solution at all. Still could only have 1 RPC provider for a given chain.

Is there any particular reason for Rabby to force users to only have 1 RPC per chain since adding custom RPC intentionally checks for duplication chainID?

xtools-at commented 2 weeks ago

it kinda makes sense that the chain id is the "unique identifier" in this context and may be used for chain selection.

what's your use case? connecting to the same chain with different rpcs?

0xGitGuy commented 2 weeks ago

yes, same chain diff rpc. mevblock has different variants of rpc that produces different results (revert vs no revert). The public rpc produces the pending mempool txn. I use them for various trading and dev mainnet testing purposes. Sticking to 1 rpc means i have to toggle between rabby and metamask as a tradeoff, not a pleasant UX