RabbyHub / Rabby

The game-changing wallet for Ethereum and all EVM chains
https://rabby.io
Other
1.41k stars 407 forks source link

Feat: Add Button to Display Address on Ledger #2591

Open ethDreamer opened 2 weeks ago

ethDreamer commented 2 weeks ago

All Ledger devices include a screen, enabling users to securely verify wallet addresses directly on the device. This feature is essential to the security model of hardware wallets, allowing users to confirm they truly control the keys for a particular address before sending funds. Without this feature, compromised wallet software can easily deceive users into sending funds to an attacker-controlled address.

This PR serves as a working proof of concept to show how straightforward it is to implement this feature. If a Rust dev with almost no TypeScript experience and no prior familiarity with this codebase can set this up in a few hours, it seems feasible that the dev team could properly integrate this functionality very easily.

I hope this demonstrates its value and feasibility – and I encourage the team to consider it for the security benefits it provides.