search

Rabobank-Archive / rule-engine

A rule engine supporting forward chaining
MIT License
47 stars 5 forks source link

translate Rule Engine DSL to English #4

Open jhkuperus opened 8 years ago

jhkuperus commented 8 years ago

The features inside the Rule Engine DSL should preferably be abstracted over and have an English translation implemented as well.

NRBPerdijk commented 8 years ago

Has there been any recent progress on this story?

jhkuperus commented 8 years ago

I don't think so. Feel free to pickup the branch and translate some stuff. We can look at how it fits V's plans together. (Or maybe he'll pick it up since I heard he was a bit bored) ^_^

tculshaw commented 8 years ago

Hi There!

Currently looking at rules for a scala project I'm working on. What's the approx revised timeline for a release in English? I notice the branch is stale, but obviously a lot of effort had already gone into it?

jhkuperus commented 8 years ago

The finance DSL is actually done, I'm going to open a PR for it today. We were revamping the translation of the rules-part of the DSL since we just submitted a CFP-proposal for it.

When would you need it? We'll gladly put it on the top of our list for you :)

tculshaw commented 8 years ago

Quick reply:) I'm hoping to put it in as an extension proposal to a project I'm working on in the travel industry. Obviously I'd be keen to see the DSL released, but I can't honestly say I need it yesterday! Happy to get a rough idea though:)

On Aug 22, 2016 6:12 PM, "Jan-Hendrik Kuperus" notifications@github.com wrote:

The finance DSL is actually done, I'm going to open a PR for it today. We were revamping the translation of the rules-part of the DSL since we just submitted a CFP-proposal for it.

When would you need it? We'll gladly put it on the top of our list for you :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scala-rules/rule-engine/issues/4#issuecomment-241322684, or mute the thread https://github.com/notifications/unsubscribe-auth/AAianTwTp9SFV3MMVJ4APl6sY9gcf0eCks5qiT3YgaJpZM4IG0mO .

jhkuperus commented 8 years ago

We talked about it today and decided to make this our top priority. Tuesday or Wednesday you'll see a brand new branch pop up for this. (The current branch is too outdated, so we'll be better off cherrypicking what we have onto a new branch). Then we'll try to get it done in the next two or three weeks.

tculshaw commented 8 years ago

Fantastic!

On 23 August 2016 at 06:46, Jan-Hendrik Kuperus notifications@github.com wrote:

We talked about it today and decided to make this our top priority. Tuesday or Wednesday you'll see a brand new branch pop up for this. (The current branch is too outdated, so we'll be better off cherrypicking what we have onto a new branch). Then we'll try to get it done in the next two or three weeks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scala-rules/rule-engine/issues/4#issuecomment-241510535, or mute the thread https://github.com/notifications/unsubscribe-auth/AAianVqNEu9VR5hovHgxai9axTF-DP2tks5qie53gaJpZM4IG0mO .

vzorge commented 8 years ago

I have integrated the changes made into the Translation branch. I now have everything compiling and ready to build further. There are a few new additions to the Dsl that I still need to incorporate into the English translation.

I want to give it a small overhaul before I push these changes. I expect to do a push on saturday the 27th of august, with compiling and working DSL in English. Not sure if I can incorporate all the new features yet, but will do my best.

tculshaw commented 8 years ago

On leave next week, but will give it a go on my return. If it goes smoothly I'd be happy to contribute any examples I build.

jhkuperus commented 8 years ago

As soon as you've pushed it, we'll run it against our client's project to see if maybe you've broken anything ;)

vzorge commented 8 years ago

I have pushed the merge result where everything compiles and all tests are green.

There are some things still left to do.

I will pick them up one by one, starting from the top

vzorge commented 8 years ago

I would appreciate a review. I made some choices regarding translations and would like to see what you guys think.

NRBPerdijk commented 8 years ago

It's going to sound like a cop-out but for now I don't have any remarks. I think we will need to keep a close look at how the english DSL will actually be used in practice, to see if any of the keywords need adjustment or alternatives...