search

RachelChua / pe

0 stars 0 forks source link

List problem due to adding of a patient instead of nurse #6

Open RachelChua opened 1 year ago

RachelChua commented 1 year ago

image.png

I added the nurse, Lily by the add command. But with list for nurse it did not appear, due to the fact that Lily was added as a patient rather than a nurse. Hence, making the previous issue regarding this more severe.

soc-pe-bot commented 1 year ago

Team's Response

This is caused by not being able to add nurse (issue #4030) and not caused by list command. Thus, it is a duplicate of unable to add nurse issue.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to add nurse

The current state of the contact book contains 3 instances of Jason with different surnames as shown below which are displayed via: find jason Screenshot 2022-11-11 at 4.51.16 PM.png

Following the exact instructions specified in the UG for adding a new nurse to the contact book: Screenshot 2022-11-11 at 4.53.19 PM.png

Steps to replicate:

  1. input the command add c/N n/Jason p/98723432 e/jason@example.com g/M a/Blk 855 Woodlands Street 83, Singapore 730855, block 123, #01-01 t/asthma ud/2022-11-11

Screenshot 2022-11-11 at 4.54.46 PM.png

  1. Upon pressing the enter key,

Screenshot 2022-11-11 at 4.56.06 PM.png

As a user of the application I will not be able to add a nurse to the application which disrupts my usage drastically.

[original: nus-cs2103-AY2223S1/pe-interim#3978] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The team has found the cause of this bug which is the removal of a critical else clause which checks if the user wants to add a nurse or a patient, and returns either a nurse or a patient respectively. Please refer to lines 94-99 of this commit.

Due to this bug, several other features like the list command were affected as seen in issue #3816. It can be shown that the bug in issue #3816 and this are caused by the same lines of code in the above commit, and therefore we have marked #3816 as a duplicate. #3412, #5595 and #4445 are also clearly the same issue and hence are marked as duplicates.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.High] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]