search

Rachelwebdev / recipe-app

MIT License
2 stars 1 forks source link

Ruby on Rails group project #7

Open Rachelwebdev opened 1 year ago

Rachelwebdev commented 1 year ago

https://github.com/users/Rachelwebdev/projects/3/views/1

NOTE: There are 2 people in my team @Rachelwebdev and @uchexm

Davidosky007 commented 1 year ago

Hi @Rachelwebdev @uchexm 👋,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project with a broken link, the link you provided is broken , kindly provide a working link

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Rachelwebdev commented 1 year ago

@Davidosky007 . Thanks for the review but is it the issues link that is broken or the project link? The project link is working fine on my end

Davidosky007 commented 1 year ago

@Davidosky007 . Thanks for the review but is it the issues link that is broken or the project link? The project link is working fine on my end

The project link is broken, when I click on it it takes me to a 404 not found page instead of the kanban board page

Rachelwebdev commented 1 year ago

@Davidosky007 I have seen the reason. The project was set to private. I have corrected it now. Thanks

Qoosim commented 1 year ago

Status: Required Changes :recycle:

Hi @team,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Required Changes ♻️

Check the comments under the review.

board-2

project-rqt

board-1

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

TedLivist commented 1 year ago

STATUS: APPROVED ✔️ ✔️

Hi @Rachelwebdev and @uchexm,

✔️ Tasks are properly assigned

Your project is complete! There is nothing else to say other than... it's time to go ahead with the project :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.