search

RackSec / desdemona

Data-backed security operations
Eclipse Public License 1.0
2 stars 7 forks source link

Multi-arity featurec #118

Closed lvh closed 8 years ago

lvh commented 8 years ago

Closes #106, #117. Builds on #111.

lvh commented 8 years ago

This adds a new feature, so I should probably add an explicit test that just runs the query.

lvh commented 8 years ago

Oh, and this does not yet solve the infix version of this problem... But that should probably be a different ticket/PR so as to keep these as small as possible...

codecov-io commented 8 years ago

Current coverage is 92.00%

Merging #118 into master will decrease coverage by -0.23% as of 8c6ae06

@@            master   #118   diff @@
=====================================
  Files           17     17       
  Stmts          219    225     +6
  Branches        10     11     +1
  Methods          0      0       
=====================================
+ Hit            202    207     +5
- Partial         10     11     +1
  Missed           7      7

Review entire Coverage Diff as of 8c6ae06

Powered by Codecov. Updated on successful CI builds.

lvh commented 8 years ago

OK. I've added the test and I'm working on the infix stuff in a separate PR; so this is ready for review after #111, which it is dependent on.

lvh commented 8 years ago

I have also filed #119 since that is some presumably-confusing behavior we're getting out of the logic engine here.

derwolfe commented 8 years ago

This looks good to go - Thanks!