search

RackSec / desdemona

Data-backed security operations
Eclipse Public License 1.0
2 stars 7 forks source link

rearrange the dockerfile to make lein deps cacheable #126

Closed reaperhulk closed 8 years ago

reaperhulk commented 8 years ago

This should make it so we only have to re-run lein deps if project.clj changes.

lvh commented 8 years ago

This feels like a hacky workaround for what should really just be a local Maven repo, but I appreciate that maybe that just comes with its own set of problems as well.

lvh commented 8 years ago

(Also the failing build seems to indicate that it doesn't work because it can't find project.clj. This is because Docker is not very clever: try adding a trailing slash to the destination part of the COPY instruction.)

reaperhulk commented 8 years ago

Looks like old docker is not clever and newer docker is. The jenkins builder had no problems ;)

lvh commented 8 years ago

Huh, weird. I just checked the documentation and it provides no indication that this changed :/

lvh commented 8 years ago

so maybe we should just kill the docker build on travis in this PR or something :/

reaperhulk commented 8 years ago

Up to you. I can add the slash as well since it's not a big deal and then we could kill travis docker in the next PR?

lvh commented 8 years ago

Supporting old docker is probably better than not supporting old docker, so that plan seems fine to me :)

codecov-io commented 8 years ago

Current coverage is 92.00%

Merging #126 into master will not affect coverage as of b2379f7

@@            master   #126   diff @@
=====================================
  Files           17     17       
  Stmts          225    225       
  Branches        11     11       
  Methods          0      0       
=====================================
  Hit            207    207       
  Partial         11     11       
  Missed           7      7

Review entire Coverage Diff as of b2379f7

Powered by Codecov. Updated on successful CI builds.