search

RackSec / desdemona

Data-backed security operations
Eclipse Public License 1.0
2 stars 7 forks source link

Specify line length in editorconfig #130

Closed lvh closed 8 years ago

ehashman commented 8 years ago

This LGTM, but the build failed because the badges on the README (lines 3-4) are too long. Is there any way to ignore that? I can merge this but the build is going to break from now on as a result.

codecov-io commented 8 years ago

Current coverage is 92.00%

Merging #130 into master will not affect coverage as of 9de53d5

@@            master   #130   diff @@
=====================================
  Files           17     17       
  Stmts          225    225       
  Branches        11     11       
  Methods          0      0       
=====================================
  Hit            207    207       
  Partial         11     11       
  Missed           7      7

Review entire Coverage Diff as of 9de53d5

Powered by Codecov. Updated on successful CI builds.

lvh commented 8 years ago

Looks like the only granularity you can get there is file-level. Since part of this touched the README, I'm disinclined to do that. However, I used markdown ref syntax instead to just make the line shorter :) (Also I think that most Markdown parsers may even accept newlines inside matched delimiters)

ehashman commented 8 years ago

The badges are rendering weird for me: https://github.com/lvh/desdemona/blob/b9e7e7c2b2767a7634a74edf790ae8ccf91a6972/README.md

sirsean commented 8 years ago

👍