Closed sirsean closed 8 years ago
cljfmt is beside itself with anger. Appease the cljfmt gods!
master
now makes kibit non-gating for the threading (#16) issue
52.50%
Merging #21 into master will decrease coverage by -23.43% as of
b3ba040
@@ master #21 diff @@
=====================================
Files 15 17 +2
Stmts 399 280 -119
Branches 26 5 -21
Methods 0 0
=====================================
- Hit 303 147 -156
+ Partial 26 5 -21
- Missed 70 128 +58
Review entire Coverage Diff as of
b3ba040
Powered by Codecov. Updated on successful CI builds.
This PR has tabs all over it.
classic golang party foul
What's the Clojure-preferred indentation style? (And why doesn't cljfmt
fix it.)
Well, obviously whatever clojure-mode
does ;) I'll check into why cljfmt doesn't fix it. Typically it's 4 spaces roughly, except for defs and hanging indents, i.e.
(defn run-query
([query events]
(run-query 1 query events))
([n-answers query events]
(eval (gen-query n-answers query events))))
Lines 3 and 5 "hang" where 2 and 4 do.
cljfmt allegedly does fix indentation: https://github.com/weavejester/cljfmt#configuration
Perhaps it only fixes local style?
I am merging this despite the codecov failure; the code we care about is tested, the untested code comes straight from the template; we'll be addressing individual coverage improvements after this PR.
Backported support for Docker Compose and Kafka.
Using Kafka to read lines and save them into a MySQL database. (This was stolen directly from the Onyx template. Obviously we need to change how/where it gets stored.)
Using a syslog-ng relay that receives syslog lines and passes them along to Kafka.
docker-compose up
will start the whole thing.Before you can do anything else, you need to create the Kafka topic:
(And then type anything. Or you could just send syslog to your Docker host on port 601.)
You also need to create the database table:
And then you can submit the job!
And then whatever you send to syslog on that host should go through Kafka and appear in MySQL.